This repository was archived by the owner on Jul 14, 2023. It is now read-only.
Add integration test playbook. #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdero
suggested changes
Nov 5, 2016
Contributor
bdero
left a comment
bdero
left a comment
There was a problem hiding this comment.
Just a couple of tiny change requests, one to work around a bug in Ansible. I was able to complete the test playbook successfully though. :)
tests/integration.yml
Outdated
| wait_for: | ||
| path: "{{ LOAD_BALANCER_CERTS_DIR }}/{{ TEST_DOMAIN }}.pem" | ||
| timeout: 360 | ||
| - name: wait for haproxy to be restartet |
Contributor
There was a problem hiding this comment.
Small typo: s/restartet/restarted
| - name: start pydoc as test backend on the server | ||
| command: nohup pydoc -p 5000 | ||
| async: 45 | ||
| poll: 0 |
Contributor
There was a problem hiding this comment.
So I think I ran into this bug with ansible==2.0.1.0 on this async task:
fatal: [haproxy-test.bdero.me]: FAILED! => {"changed": false, "failed": true, "msg": "The async task did not return valid JSON: No JSON object could be decoded"}
I was able to steer around the problem by appending become: False. Can you add it in here since escalating to root isn't necessary for this task anyway?
Contributor
Author
|
@bdero Thanks for you comments! The issues are fixed in the latest commit. |
Contributor
|
👍
|
bdero
approved these changes
Nov 5, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing instructions are included in the README.md file.